使用正则表达式破坏所有 JavaScript 的 JavaScript 验证

我正在编写javascript来验证业务计算器/订单另一个队友写了数学代码，但是当我输入代码时，整个事情就停止了。我找不到我的错误（我更像是一个 css/html 人）帮助？

//Order Detail Variables//
var clientname =document.getElementById(clientname);
var phonenumber =document.getElementById(phoneno);
var deliveryaddress=document.getElementById(deliveryaddress);
var suburb =document.getElementById(suburb);
var postcode =document.getElementById(postcode);
var state =document.getElementById(state);
var deliverydistance = document.getElementById(deldistance);
var bagsordered =document.getElementById(bagsordered);
var orderdetailsarray = new Array();
//validation//
// these are boolean variables that when made true// 
//by the validation will allow the calculation and logging to occur//
var clientnamevalid = new Boolean(false);
//Regex Variables//
//these are the regex patterns that are used to //
//confirm that the data is valid//
var alpha = pattern=/^[a-zA-Z'-]+$/;
function validation()
    {
    function validation();
        {console.log (clientname);
        if(alpha.test(clientname));
        var clientnamevalid = true;
            if { clientnamevalid = true; 
                alert(client name valid); //to be replaced with inline alert
        }
            else {
                alert("client name invalid"); 
        }
    }

编辑更新的代码：

瓦尔现在是

var clientname =document.getElementById('clientname');

函数：

function validation()
        {console.log (clientname);
        var clientnamevalid = alpha.test(clientname);
        if(clientnamevalid);
        {
            alert('client name valid')  
        }
        else 
        {   
        alert("client name invalid");        
        }
    }

编辑更新的代码 2：

<button name="calculate" id="calcbutton" onclick="validate()"> Calculate </button>
function validate()

{console.log (clientname);
    var clientnamevalid = alpha.test(clientname);
    if(clientnamevalid);
    {
        alert('client name valid'); 
    }
    else 
    {   
    alert("client name invalid");        
    }
    if clientnamevalid = true;
    {   
        function calculateorder();
    }
}

编辑 3：

function validate()
        {console.log (clientname);
        var clientnamevalid = alpha.test(clientname);
        if(clientnamevalid);
        {
            alert("client name valid"); //edited from single quotations
        }
        else 
        {   
        alert("client name invalid");        
        }
        if (clientnamevalid == true);
        {   
            calculateorder();
        }
        else
        {
        alert ("please review form");
        }
    }

计算顺序功能：

function calculateorder()
    {
            orderdetailsarray [0] = document.forms["orderform1"] ["clientname"].value; 
            orderdetailsarray [1] = document.forms["orderform1"] ["phoneno"].value ;
            orderdetailsarray [2] = document.forms["orderform1"] ["deliveryaddress"].value;
            orderdetailsarray [3] = document.forms["orderform1"] ["suburb"].value;
            orderdetailsarray [4] = document.forms["orderform1"] ["postcode"].value;    
            orderdetailsarray [6] = parseFloat(document.forms["orderform1"] ["deldistance"].value);
            orderdetailsarray [7] = parseFloat(document.forms["orderform1"] ["bagsordered"].value);
            orderdetailsarray [8] = document.forms["orderform1"] ["orderdate"].value;
        //gross calculation 
        var grossbagcost = orderdetailsarray[7] * millendcost;
        grossbagcost = Math.round(grossbagcost *100)/100;
        document.forms["resultsform"] ["bagsgross"].value = grossbagcost;
        //end gross calculation
        //discount amount calculation
        if (orderdetailsarray [7] <=50)
        {
            var discountedbagcost = grossbagcost * discountnil;
            document.forms["resultsform"] ["discount"].value = discountedbagcost;
        }
        else if (orderdetailsarray[7] >50 && orderdetailsarray[7] <100)
        {
            var discountedbagcost = grossbagcost * discount4percent;
            discountedbagcost = Math.round(discountedbagcost *100)/100;
            document.forms["resultsform"] ["discount"].value = discountedbagcost;
        }
        else if (orderdetailsarray[7] >=100)
        {
            var discountedbagcost = grossbagcost * discount7percent;
            discountedbagcost = Math.round(discountedbagcost *100)/100;
            document.forms["resultsform"] ["discount"].value = discountedbagcost;
        }

使用空检查更新的代码

function validate()
    {console.log (clientname);
        //pattern test
        var clientnamevalid == alpha.test(clientname);
        if(clientnamevalid);
        {
            alert("client name valid");
        }
        else 
        {   
            alert("client name invalid");   
        //null check    
        }   
        if (x==null || x=="")
        {
            alert("Client name cannot be left blank");
                clientnamenotnull == false;
        }
        else
        { 
            clientnamenotnull == true;
        }
        //is the whole form valid
    {
        if (clientnamevalid == true)
        if (clientnamenotnull) == true)
        {   
            calculateorder();
        }
        else
        {
        alert ("please review form");
        }
    }